fix: support other port than 443

[delcroip]

No description provided.

[issa-tseng]

hey @delcroip:

we're all a little busy over here, but we'll take a look at this soon. thanks for sending this in.
it's looking okay to me at a first glance, but the port stuff gets complicated and passed into a bunch of places so it'll take a minute just to work through it all.

curious, what have you verified these changes by?

[delcroip]

Hi,

l deployed it on my windows laptop on port 2443 (443 was already taken) in order to test forms while being in the plane, you can find the details of the config used there https://forum.getodk.org/t/could-not-connect-with-form-server-preview/35789/6?u=delcroip

It works fine since then

br

[yanokwa]

I have confirmed the following scenarios with a custom SSL cert and HTTPS port 8443:

• The password reset email that is sent has the port information
• Form downloads and submissions sending in Collect works
• Previews and submission sending in Enketo works
• CSV downloads and OData feed have submission data
• Rebuild with LetsEncrypt on port 443 works and front page loads
• Rebuild with custom SSL on port 8444 (different port than original) works and front page loads
  • New app user Collect submissions work, old ones do not.
  • New Enketo previews work, old ones do not.

The one issue I see is:

• The nginx healthcheck fails with this PR. Relatedly, going to the http://domain.com doesn't redirect to https://domain.com:8443 as one would hope.

Another thing to consider is what happens if someone wants to run HTTP on something besides port 80. That is they want to go to http://domain.com:8081 and redirect to https://domain.com:8443. How do we (or do we) support that.

I discussed the above with @lognaturel and her bias is to merge and address the issue I found in a follow on PR.