Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v3.2.0 snapshot versions #625

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

lognaturel
Copy link
Member

Update versions for v3.2.0 snapshot.

@codecov-io
Copy link

Codecov Report

Merging #625 (e9c0597) into master (18391aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #625   +/-   ##
=========================================
  Coverage     55.20%   55.20%           
  Complexity     3270     3270           
=========================================
  Files           246      246           
  Lines         13389    13389           
  Branches       2573     2573           
=========================================
  Hits           7391     7391           
  Misses         5201     5201           
  Partials        797      797           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18391aa...e9c0597. Read the comment docs.

@lognaturel lognaturel marked this pull request as draft March 24, 2021 04:41
@lognaturel
Copy link
Member Author

lognaturel commented Mar 24, 2021

@dcbriccetti, @getodk/testers I was optimistic about getting this to QA today but I'm now getting behavior in Collect that I don't understand. Will update as I know more.

First it looks like IAnswerData objects are rebuilt as a form gets navigated. The values that they wrap are identical and also have sensible equals but IAnswerData subclasses don't override equals which means Objects.equals(currentTriggerValues, cachedTriggerValues) is never true during form navigation. I think I can fix that by defining equals in each of the IAnswerData subclasses. Even better would be if Collect were closer to the raw JR behavior but I don't know how realistic that is. I'll explore.

Looking into that first issue, I also discovered that FormEntryPrompt.getSelectItemText is now crashing on form re-entry because when the call sel.choice.getTextID() is made, sel.choice is null. I don't know what that's about and my first step when I get a chance will be to try to write a JavaRosa test that captures this.

@lognaturel
Copy link
Member Author

#626 Addresses the issues we identified so we're now ready for a snapshot.

@lognaturel lognaturel marked this pull request as ready for review April 13, 2021 14:59
@lognaturel lognaturel requested a review from yanokwa April 13, 2021 14:59
@yanokwa yanokwa merged commit 595b760 into getodk:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants