Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XCFramework Path #3760

Merged
merged 3 commits into from
Mar 19, 2024
Merged

fix: XCFramework Path #3760

merged 3 commits into from
Mar 19, 2024

Conversation

brustolin
Copy link
Contributor

The path to the XCFramework in the package.json was incorrect before releasing the new version, so the bump tool did not properly update it.

Closes #3759

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Philipp Hofmann <[email protected]>
@brustolin brustolin merged commit aa4eddf into main Mar 19, 2024
1 of 2 checks passed
@brustolin brustolin deleted the fix/xcframework-path branch March 19, 2024 07:28
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- XCFramework Path ([#3760](https://github.com/getsentry/sentry-cocoa/pull/3760))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d7d1297

threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
* fix path

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Philipp Hofmann <[email protected]>

---------

Co-authored-by: Philipp Hofmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksums for 8.22.0 binaries seem to be incorrect
2 participants