Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Session replay video size #4018

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix: Session replay video size #4018

merged 2 commits into from
May 28, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Session replay used to have a hardcoded video size. Now it gets from the window size

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.861%. Comparing base (86b89b9) to head (9bbf62c).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4018       +/-   ##
=============================================
- Coverage   90.895%   90.861%   -0.035%     
=============================================
  Files          599       598        -1     
  Lines        46690     46614       -76     
  Branches     16726     16669       -57     
=============================================
- Hits         42439     42354       -85     
- Misses        4069      4077        +8     
- Partials       182       183        +1     
Files Coverage Δ
Sources/Sentry/SentrySessionReplay.m 86.792% <100.000%> (+0.168%) ⬆️
...tions/SessionReplay/SentrySessionReplayTests.swift 98.540% <100.000%> (+0.127%) ⬆️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b89b9...9bbf62c. Read the comment docs.

Copy link

github-actions bot commented May 27, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.52 ms 1249.92 ms 22.40 ms
Size 21.58 KiB 638.28 KiB 616.70 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5d6ce0e 1237.10 ms 1257.46 ms 20.36 ms
7e8d5fd 1208.69 ms 1228.14 ms 19.45 ms
84fb4d9 1237.76 ms 1255.46 ms 17.70 ms
21fd61f 1226.42 ms 1247.52 ms 21.10 ms
51ffd8c 1194.60 ms 1215.70 ms 21.10 ms
45d3ca5 1248.27 ms 1255.48 ms 7.21 ms
e324230 1244.43 ms 1252.98 ms 8.55 ms
1734d1b 1200.15 ms 1214.06 ms 13.92 ms
4886e79 1248.43 ms 1255.04 ms 6.61 ms
965db8a 1211.61 ms 1226.60 ms 14.99 ms

App size

Revision Plain With Sentry Diff
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
7e8d5fd 20.76 KiB 435.50 KiB 414.74 KiB
84fb4d9 22.84 KiB 402.57 KiB 379.72 KiB
21fd61f 20.76 KiB 435.50 KiB 414.74 KiB
51ffd8c 21.58 KiB 418.70 KiB 397.11 KiB
45d3ca5 20.76 KiB 427.54 KiB 406.78 KiB
e324230 22.85 KiB 408.88 KiB 386.03 KiB
1734d1b 21.58 KiB 418.82 KiB 397.23 KiB
4886e79 22.85 KiB 412.98 KiB 390.13 KiB
965db8a 22.84 KiB 403.24 KiB 380.39 KiB

Previous results on branch: fiz(SR)/replay-size

Startup times

Revision Plain With Sentry Diff
a277be7 1224.61 ms 1244.00 ms 19.39 ms

App size

Revision Plain With Sentry Diff
a277be7 21.58 KiB 638.29 KiB 616.71 KiB

@brustolin brustolin merged commit b0e218b into main May 28, 2024
67 of 70 checks passed
@brustolin brustolin deleted the fiz(SR)/replay-size branch May 28, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants