Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Session Replay): Track touches for replay #4041

Merged
merged 53 commits into from
Jun 12, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Added a touch tracker to send touch events with replays

💚 How did you test it?

Unit tests
Samples

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Jun 6, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6c3f792

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 98.35165% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.223%. Comparing base (0589699) to head (22ea1ae).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4041       +/-   ##
=============================================
+ Coverage   91.093%   91.223%   +0.129%     
=============================================
  Files          608       611        +3     
  Lines        47540     47910      +370     
  Branches     17049     17211      +162     
=============================================
+ Hits         43306     43705      +399     
+ Misses        4164      4135       -29     
  Partials        70        70               
Files Coverage Δ
SentryTestUtils/TestCurrentDateProvider.swift 91.176% <100.000%> (+1.521%) ⬆️
Sources/Sentry/SentryScope.m 97.457% <ø> (ø)
Sources/Sentry/SentrySessionReplay.m 87.790% <100.000%> (+0.365%) ⬆️
Sources/Sentry/SentrySessionReplayIntegration.m 94.936% <100.000%> (+1.494%) ⬆️
Sources/Swift/Extensions/NumberExtensions.swift 100.000% <100.000%> (ø)
...rations/SessionReplay/RRWeb/SentryRRWebEvent.swift 100.000% <ø> (ø)
...ns/SessionReplay/RRWeb/SentryRRWebTouchEvent.swift 100.000% <100.000%> (ø)
...ntegrations/SessionReplay/SentryTouchTracker.swift 100.000% <100.000%> (ø)
...tions/SessionReplay/SentrySessionReplayTests.swift 98.550% <100.000%> (+0.010%) ⬆️
...ations/SessionReplay/SentryTouchTrackerTests.swift 100.000% <100.000%> (ø)
... and 2 more

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0589699...22ea1ae. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't fully review this yet. There is plenty of logic in here, so I will give this another pass next week.

Copy link

github-actions bot commented Jun 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.10 ms 1231.98 ms 11.87 ms
Size 21.58 KiB 669.35 KiB 647.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6943de0 1215.83 ms 1253.22 ms 37.39 ms
9cc7e7c 1228.90 ms 1237.96 ms 9.06 ms
0559a8f 1239.78 ms 1252.60 ms 12.83 ms
ef284b2 1211.76 ms 1229.69 ms 17.93 ms
b9a9ffd 1201.61 ms 1215.06 ms 13.45 ms
add9550 1228.15 ms 1247.58 ms 19.44 ms
e84bc3f 1196.62 ms 1218.86 ms 22.24 ms
736495a 1245.16 ms 1254.42 ms 9.26 ms
32ac934 1224.46 ms 1243.16 ms 18.70 ms
326b7eb 1223.41 ms 1235.66 ms 12.25 ms

App size

Revision Plain With Sentry Diff
6943de0 20.76 KiB 393.33 KiB 372.57 KiB
9cc7e7c 22.84 KiB 403.13 KiB 380.29 KiB
0559a8f 21.58 KiB 419.81 KiB 398.23 KiB
ef284b2 20.76 KiB 401.36 KiB 380.60 KiB
b9a9ffd 21.58 KiB 418.43 KiB 396.85 KiB
add9550 21.58 KiB 418.37 KiB 396.79 KiB
e84bc3f 20.76 KiB 434.72 KiB 413.96 KiB
736495a 20.76 KiB 435.22 KiB 414.46 KiB
32ac934 21.58 KiB 616.72 KiB 595.14 KiB
326b7eb 20.76 KiB 432.31 KiB 411.55 KiB

Previous results on branch: feat(SR)/touches-breadcrumbs

Startup times

Revision Plain With Sentry Diff
084dab9 1229.27 ms 1248.90 ms 19.63 ms
7fd4734 1233.82 ms 1252.73 ms 18.92 ms
b9b1145 1231.90 ms 1245.43 ms 13.53 ms
b86e190 1237.60 ms 1251.84 ms 14.24 ms
c6f1870 1230.88 ms 1237.83 ms 6.96 ms

App size

Revision Plain With Sentry Diff
084dab9 21.58 KiB 670.09 KiB 648.51 KiB
7fd4734 21.58 KiB 670.05 KiB 648.47 KiB
b9b1145 21.58 KiB 670.03 KiB 648.45 KiB
b86e190 21.58 KiB 668.62 KiB 647.03 KiB
c6f1870 21.58 KiB 669.98 KiB 648.40 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with mostly suggestions to improve the readability of the code.

@brustolin brustolin enabled auto-merge (squash) June 10, 2024 13:30
@brustolin brustolin merged commit beb7ff7 into main Jun 12, 2024
@brustolin brustolin deleted the feat(SR)/touches-breadcrumbs branch June 12, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants