-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Session Replay): Track touches for replay #4041
Conversation
…dcrumbEvent.swift Co-authored-by: Roman Zavarnitsyn <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4041 +/- ##
=============================================
+ Coverage 91.093% 91.223% +0.129%
=============================================
Files 608 611 +3
Lines 47540 47910 +370
Branches 17049 17211 +162
=============================================
+ Hits 43306 43705 +399
+ Misses 4164 4135 -29
Partials 70 70
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't fully review this yet. There is plenty of logic in here, so I will give this another pass next week.
Sources/Swift/Integrations/SessionReplay/SentryTouchTracker.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryTouchTracker.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryTouchTracker.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryTouchTracker.swift
Outdated
Show resolved
Hide resolved
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6943de0 | 1215.83 ms | 1253.22 ms | 37.39 ms |
9cc7e7c | 1228.90 ms | 1237.96 ms | 9.06 ms |
0559a8f | 1239.78 ms | 1252.60 ms | 12.83 ms |
ef284b2 | 1211.76 ms | 1229.69 ms | 17.93 ms |
b9a9ffd | 1201.61 ms | 1215.06 ms | 13.45 ms |
add9550 | 1228.15 ms | 1247.58 ms | 19.44 ms |
e84bc3f | 1196.62 ms | 1218.86 ms | 22.24 ms |
736495a | 1245.16 ms | 1254.42 ms | 9.26 ms |
32ac934 | 1224.46 ms | 1243.16 ms | 18.70 ms |
326b7eb | 1223.41 ms | 1235.66 ms | 12.25 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6943de0 | 20.76 KiB | 393.33 KiB | 372.57 KiB |
9cc7e7c | 22.84 KiB | 403.13 KiB | 380.29 KiB |
0559a8f | 21.58 KiB | 419.81 KiB | 398.23 KiB |
ef284b2 | 20.76 KiB | 401.36 KiB | 380.60 KiB |
b9a9ffd | 21.58 KiB | 418.43 KiB | 396.85 KiB |
add9550 | 21.58 KiB | 418.37 KiB | 396.79 KiB |
e84bc3f | 20.76 KiB | 434.72 KiB | 413.96 KiB |
736495a | 20.76 KiB | 435.22 KiB | 414.46 KiB |
32ac934 | 21.58 KiB | 616.72 KiB | 595.14 KiB |
326b7eb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
Previous results on branch: feat(SR)/touches-breadcrumbs
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
084dab9 | 1229.27 ms | 1248.90 ms | 19.63 ms |
7fd4734 | 1233.82 ms | 1252.73 ms | 18.92 ms |
b9b1145 | 1231.90 ms | 1245.43 ms | 13.53 ms |
b86e190 | 1237.60 ms | 1251.84 ms | 14.24 ms |
c6f1870 | 1230.88 ms | 1237.83 ms | 6.96 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
084dab9 | 21.58 KiB | 670.09 KiB | 648.51 KiB |
7fd4734 | 21.58 KiB | 670.05 KiB | 648.47 KiB |
b9b1145 | 21.58 KiB | 670.03 KiB | 648.45 KiB |
b86e190 | 21.58 KiB | 668.62 KiB | 647.03 KiB |
c6f1870 | 21.58 KiB | 669.98 KiB | 648.40 KiB |
Sources/Swift/Integrations/SessionReplay/SentryTouchTracker.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with mostly suggestions to improve the readability of the code.
📜 Description
Added a touch tracker to send touch events with replays
💚 How did you test it?
Unit tests
Samples
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps