Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): Trigger button aria label configuration #13008

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

c298lee
Copy link
Contributor

@c298lee c298lee commented Jul 22, 2024

Adds triggerAriaLabel to configure the aria label of the trigger button.
The aria label is set to the first value that's non-empty:

  1. triggerAriaLabel
  2. triggerLabel
  3. TRIGGER_LABEL ("Report a Bug")

Closes #12505

Copy link
Contributor

github-actions bot commented Jul 22, 2024

size-limit report 📦

Path Size
@sentry/browser 22.31 KB (added)
@sentry/browser (incl. Tracing) 33.72 KB (added)
@sentry/browser (incl. Tracing, Replay) 69.81 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.15 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.21 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 86.57 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 88.44 KB (added)
@sentry/browser (incl. metrics) 26.62 KB (added)
@sentry/browser (incl. Feedback) 39.02 KB (added)
@sentry/browser (incl. sendFeedback) 26.93 KB (added)
@sentry/browser (incl. FeedbackAsync) 31.57 KB (added)
@sentry/react 25.08 KB (added)
@sentry/react (incl. Tracing) 36.8 KB (added)
@sentry/vue 26.45 KB (added)
@sentry/vue (incl. Tracing) 35.61 KB (added)
@sentry/svelte 22.44 KB (added)
CDN Bundle 23.52 KB (added)
CDN Bundle (incl. Tracing) 35.5 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.9 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.2 KB (added)
CDN Bundle - uncompressed 69 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 105.1 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 216.88 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.71 KB (added)
@sentry/nextjs (client) 36.66 KB (added)
@sentry/sveltekit (client) 34.39 KB (added)
@sentry/node 111.76 KB (added)
@sentry/node - without tracing 89.21 KB (added)
@sentry/aws-serverless 98.34 KB (added)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! Can we add tests that ensure the cascading behavior is correct? E.g. what is the aria-label by default, what if trigger label is empty, ...?

@c298lee c298lee requested review from mydea and billyvg July 23, 2024 17:32
@c298lee c298lee merged commit 65042b5 into develop Jul 23, 2024
125 checks passed
@c298lee c298lee deleted the cl/uf-aria-label branch July 23, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Feedback] Add Option to Choose Mobile Version of the Trigger Button
4 participants