-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs): Add bundleSizeOptimizations
to build options
#13323
Changes from 3 commits
4fa73fd
5e920b8
0723120
013e1de
ee09a02
ecef80c
27ce9fb
d927f72
653c341
ca3e691
7b8e3de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,10 @@ describe('getWebpackPluginOptions()', () => { | |
env: 'my-env', | ||
}, | ||
}, | ||
bundleSizeOptimizations: { | ||
excludeTracing: true, | ||
excludeReplayShadowDom: false, | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l: Any reason we added this here? I don't see any changes to assertions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, makes sense to separate this. I created another test just for those options. |
||
}); | ||
|
||
expect(generatedPluginOptions.authToken).toBe('my-auth-token'); | ||
|
@@ -105,6 +109,10 @@ describe('getWebpackPluginOptions()', () => { | |
}, | ||
telemetry: false, | ||
url: 'my-url', | ||
bundleSizeOptimizations: { | ||
excludeTracing: true, | ||
excludeReplayShadowDom: false, | ||
}, | ||
}); | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks off (astro != nextjs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh thanks, that's a copy paste error