Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Update OpenTelemetry instrumentation package for solidstart and opentelemetry #13640

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(node): Update OpenTelemetry instrumentation package for solidstart and opentelemetry #13640

merged 1 commit into from
Sep 10, 2024

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Sep 10, 2024 •
edited
Loading

Looks like we overlooked two packages when updating deps previously in #13587.

See: #13587 (comment)

Closes: #13219

@andreiborza andreiborza force-pushed the ab/opentelemetry-dep-update branch from a631c67 to 2a008b4 Compare September 10, 2024 01:53
@andreiborza andreiborza changed the title fix(node): Update OpenTelemetry nstrumentation packages for solidstart and opentelemetry fix(node): Update OpenTelemetry instrumentation package for solidstart and opentelemetry Sep 10, 2024
@andreiborza andreiborza mentioned this pull request Sep 10, 2024
Closed
3 tasks
@andreiborza andreiborza merged commit 0d79b51 into develop Sep 10, 2024
112 checks passed
@andreiborza andreiborza deleted the ab/opentelemetry-dep-update branch September 10, 2024 07:20
@andreiborza andreiborza mentioned this pull request Sep 10, 2024
Merged
andreiborza added a commit that referenced this pull request Sep 10, 2024
@andreiborza
fix(node): Update OpenTelemetry instrumentation package for solidstar…
703b5d4 
…t and opentelemetry (#13642)

Part 2 because I forgot to update the lockfile in the [previous
PR](#13640).
@q1blue q1blue mentioned this pull request Oct 1, 2024
Open
@wkylin wkylin mentioned this pull request Oct 2, 2024
Closed
@KeeghanM KeeghanM mentioned this pull request Oct 3, 2024
Merged
This was referenced Oct 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome chargome approved these changes

@mydea mydea Awaiting requested review from mydea

@lforst lforst Awaiting requested review from lforst

@Lms24 Lms24 Awaiting requested review from Lms24

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opentelemetry api npm peer dep broken with strict pnpm
2 participants
@andreiborza @chargome