Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Ensure graphql options are correct when preloading #13769

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 24, 2024

Noticed this by chance, due to the way generateInstrumentOnce works, we need to pass in the fully formed config.

@mydea mydea requested review from Lms24 and chargome September 24, 2024 14:59
@mydea mydea self-assigned this Sep 24, 2024
Copy link
Contributor

github-actions bot commented Sep 24, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 34.97 KB - -
@sentry/browser (incl. Tracing, Replay) 71.5 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.91 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.82 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.59 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.46 KB - -
@sentry/browser (incl. metrics) 27 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.38 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.49 KB - -
@sentry/react (incl. Tracing) 37.94 KB - -
@sentry/vue 26.9 KB - -
@sentry/vue (incl. Tracing) 36.86 KB - -
@sentry/svelte 22.87 KB - -
CDN Bundle 24.05 KB - -
CDN Bundle (incl. Tracing) 36.76 KB - -
CDN Bundle (incl. Tracing, Replay) 71.25 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.57 KB - -
CDN Bundle - uncompressed 70.53 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.04 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.01 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.23 KB - -
@sentry/nextjs (client) 37.91 KB - -
@sentry/sveltekit (client) 35.56 KB - -
@sentry/node 124.5 KB +0.01% +9 B 🔺
@sentry/node - without tracing 93.64 KB - -
@sentry/aws-serverless 103.3 KB +0.01% +2 B 🔺

View base workflow run

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a test for this as well! Can just be a unit test.

mydea added 3 commits October 8, 2024 13:06
Noticed this by chance, due to the way `generateInstrumentOnce` works, we need to pass in the fully formed config.
@mydea mydea force-pushed the fn/fix-graphql-preload branch from 991cb71 to 6e05169 Compare October 8, 2024 11:29
@mydea
Copy link
Member Author

mydea commented Oct 8, 2024

Added a unit test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants