Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Clear event buffer when full and in buffer mode #14078

Merged
merged 16 commits into from
Nov 21, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 25, 2024

This makes a change so that when the event buffer is full, we will clear it and wait for the next checkout instead of erroring and stopping the replay buffering. This does mean that it's possible an exception occurs in-between the filled buffer and the next checkout, where we will have an empty replay

Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.88 KB - -
@sentry/browser - with treeshaking flags 21.57 KB - -
@sentry/browser (incl. Tracing) 35.46 KB - -
@sentry/browser (incl. Tracing, Replay) 72.22 KB +0.1% +67 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.53 KB +0.14% +85 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.52 KB +0.11% +83 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.02 KB +0.12% +105 B 🔺
@sentry/browser (incl. Feedback) 39.63 KB +0.05% +18 B 🔺
@sentry/browser (incl. sendFeedback) 27.51 KB - -
@sentry/browser (incl. FeedbackAsync) 32.32 KB - -
@sentry/react 25.58 KB - -
@sentry/react (incl. Tracing) 38.32 KB - -
@sentry/vue 27.04 KB - -
@sentry/vue (incl. Tracing) 37.27 KB - -
@sentry/svelte 23.03 KB - -
CDN Bundle 24.04 KB - -
CDN Bundle (incl. Tracing) 37.02 KB - -
CDN Bundle (incl. Tracing, Replay) 71.81 KB +0.12% +86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.17 KB +0.11% +86 B 🔺
CDN Bundle - uncompressed 70.9 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.25 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.05 KB +0.13% +278 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.27 KB +0.12% +278 B 🔺
@sentry/nextjs (client) 38.43 KB - -
@sentry/sveltekit (client) 35.97 KB - -
@sentry/node 134.49 KB - -
@sentry/node - without tracing 96.32 KB - -
@sentry/aws-serverless 106.57 KB - -

View base workflow run

@billyvg billyvg force-pushed the feat-replay-empty-buffer-when-buffering-and-full branch from b30aae8 to e5be6d1 Compare October 31, 2024 17:20
@billyvg billyvg marked this pull request as ready for review November 1, 2024 15:36
@billyvg billyvg requested a review from a team as a code owner November 1, 2024 15:36
@getsentry getsentry deleted a comment from codecov bot Nov 1, 2024
@billyvg billyvg force-pushed the feat-replay-empty-buffer-when-buffering-and-full branch from a66a032 to bae04eb Compare November 14, 2024 19:10
@billyvg billyvg merged commit 6535500 into develop Nov 21, 2024
118 of 119 checks passed
@billyvg billyvg deleted the feat-replay-empty-buffer-when-buffering-and-full branch November 21, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants