Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): Fix non-wrapping form title #14355

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Nov 19, 2024

Fixes an issue with long form titles causing the width of the dialog to expand. Instead, apply the css var --form-width to the dialog contents so that the title wraps.

After:
image

image

Single line:
image

Closes #14351

Fixes an issue with long form titles causing the width of the dialog to expand. Instead, apply the css var `--form-width` to the dialog contents so that the title wraps.
@billyvg billyvg marked this pull request as ready for review November 19, 2024 03:20
@billyvg billyvg requested a review from a team as a code owner November 19, 2024 03:20
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.77 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.27 KB - -
@sentry/browser (incl. Tracing, Replay) 71.99 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.37 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.3 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.18 KB +0.04% +29 B 🔺
@sentry/browser (incl. Feedback) 39.96 KB +0.07% +28 B 🔺
@sentry/browser (incl. sendFeedback) 27.42 KB - -
@sentry/browser (incl. FeedbackAsync) 32.23 KB - -
@sentry/react 25.52 KB - -
@sentry/react (incl. Tracing) 38.23 KB - -
@sentry/vue 26.92 KB - -
@sentry/vue (incl. Tracing) 37.1 KB - -
@sentry/svelte 22.91 KB - -
CDN Bundle 24.13 KB - -
CDN Bundle (incl. Tracing) 37.05 KB - -
CDN Bundle (incl. Tracing, Replay) 71.71 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.06 KB - -
CDN Bundle - uncompressed 70.73 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.94 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.45 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.67 KB - -
@sentry/nextjs (client) 38.35 KB - -
@sentry/sveltekit (client) 35.85 KB - -
@sentry/node 134.33 KB - -
@sentry/node - without tracing 96.2 KB - -
@sentry/aws-serverless 106.48 KB - -

View base workflow run

@billyvg billyvg requested a review from a team November 19, 2024 15:26
@billyvg billyvg merged commit 85daf90 into develop Nov 21, 2024
124 of 126 checks passed
@billyvg billyvg deleted the feat-feedback-fix-feedback-width branch November 21, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback dialog header does not wrap with long titles
2 participants