Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entry point for opentelemetry propagator #3085

Closed
mender opened this issue May 19, 2024 · 1 comment · Fixed by #3086
Closed

Add entry point for opentelemetry propagator #3085

mender opened this issue May 19, 2024 · 1 comment · Fixed by #3086
Labels
Integration: OpenTelementry (OTel)

Comments

@mender
Copy link
Contributor

mender commented May 19, 2024

Problem Statement

According to the documentation, the recommended way to integrate with OpenTelemetry is to completely replace existing propagators using

set_global_textmap(SentryPropagator())

In case of distributed tracing it is not correct behaviour. We have to add the SentryPropagator to the existing ones instead. Opentelemetry provides environment variables as a most common way to configure it. However, propagators added via environment variables must be declared in entry points (ref). And here is an example of how entry points are declared in OpenTelemetry.

Solution Brainstorm

I propose adding entry point for SentryPropagator in setup.py.
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 May 19, 2024
mender added a commit to mender/sentry-python that referenced this issue May 19, 2024
@mender
feat(opentelemetry): Add entry point for SentryPropagator
ad91db0 
Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085
@mender mender mentioned this issue May 19, 2024
Merged
mender added a commit to mender/sentry-python that referenced this issue May 19, 2024
@mender
feat(opentelemetry): Add entry point for SentryPropagator
9e7e197 
Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085
@sentrivana
Copy link
Contributor

Thank you for the issue and the PR @mender, we will take a look.

mender added a commit to mender/sentry-python that referenced this issue May 31, 2024
@mender
feat(opentelemetry): Add entry point for SentryPropagator
b2d7644 
Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085
mender added a commit to mender/sentry-python that referenced this issue Jun 10, 2024
@mender
feat(opentelemetry): Add entry point for SentryPropagator
2f38ce7 
Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085
mender added a commit to mender/sentry-python that referenced this issue Jun 17, 2024
@mender
feat(opentelemetry): Add entry point for SentryPropagator
1a7c02a 
Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085
mender added a commit to mender/sentry-python that referenced this issue Jun 23, 2024
@mender
feat(opentelemetry): Add entry point for SentryPropagator
5a513fa 
Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@mender @sl0thentr0py @arjenzorgdoc
feat(opentelemetry): Add entry point for SentryPropagator (getsentry#…
e065817 
…3086)

Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085

Co-authored-by: Neel Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Integration: OpenTelementry (OTel)
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(opentelemetry): Add entry point for SentryPropagator mender/sentry-python
2 participants
@mender @sentrivana