Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry-debug-images is not supported on Android and iOS (with a PR) #369

Closed
fzyzcjy opened this issue Oct 14, 2021 · 5 comments
Closed

Sentry-debug-images is not supported on Android and iOS (with a PR) #369

fzyzcjy opened this issue Oct 14, 2021 · 5 comments

Comments

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Oct 14, 2021

Hi thanks for the lib! However sentry-debug-images does not support android and ios.

I have made an experiment and it shows nothing. Moreover, looking at code, it uses findshlibs, and the latter has

pub const TARGET_SUPPORTED: bool = cfg!(any(
    target_os = "macos",
    target_os = "linux",
    target_os = "windows"
));

which reveals that android&ios are not supported.

Thus, how can we symbolize images when the shipped .so file in android is stripped and symbols are removed? (originally I think I could upload unstripped .so file to sentry and let sentry parse it; but now since no loaded .so file information, sentry cannot symbolize it?)

Possible fix: Look at how backtrace symbolizes code, it uses gimli, which uses dl_iterate_phdr on android and _dyld_get_image_name etc on ios. So if we can utilize these, we can get all library information.

@fzyzcjy fzyzcjy changed the title Sentry-debug-images is not supported on Android and iOS Sentry-debug-images is not supported on Android and iOS; A possible fix may be refer to gimli Oct 14, 2021
@Swatinem
Copy link
Member

I saw your gimli-rs/findshlibs#66, so I would say that both should be supported with a simple bump of that crate.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 14, 2021

Ok

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 15, 2021

@Swatinem Hi it is merged now.

@fzyzcjy fzyzcjy changed the title Sentry-debug-images is not supported on Android and iOS; A possible fix may be refer to gimli Sentry-debug-images is not supported on Android and iOS (with a PR) Oct 16, 2021
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 16, 2021

PR: #370

@Swatinem
Copy link
Member

#370 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants