Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade findshlibs dependency #370

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Upgrade findshlibs dependency #370

merged 5 commits into from
Oct 18, 2021

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Oct 16, 2021

No description provided.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 17, 2021

findshlibs has upgraded. #369 @Swatinem

@Swatinem
Copy link
Member

Can you please rebase this? I had an update to this pending in #366 which added Windows support (and was capturing code-ids).

…o getsentry-master

# Conflicts:
#	sentry-debug-images/Cargo.toml
#	sentry-debug-images/src/images.rs
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 18, 2021

Done.

@Swatinem
Copy link
Member

Oh, it looks like CI now fails also on master because of tower-rs/tower#604 :-(
I hope this will be solved quickly so that we can merge this.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 18, 2021

all right. Waiting for it!

@Swatinem Swatinem merged commit 1bc676f into getsentry:master Oct 18, 2021
@Swatinem
Copy link
Member

I just went ahead and merged this, no need to wait for a magical CI fix if master is broken because of that anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants