feat(byteview): Expose API to apply access hints #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dav1dde
force-pushed
the
dav1d/access-hint
branch
from
3381c7d to
1686bd8
Compare
loewenheim
requested changes
Mar 5, 2025
loewenheim
approved these changes
Mar 5, 2025
Dav1dde
changed the title
Dav1dde
force-pushed
the
dav1d/access-hint
branch
from
46fc617 to
906e4f0
Compare
Dav1dde
force-pushed
the
dav1d/access-hint
branch
from
0fbf48d to
aef6c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary tests show that accessing sym-caches with
MADV_RANDOMsignificantly reduces bytes requested/read from disk. This exposes an API to apply access pattern hints toByteView.While currently this only matters for the
mmapbranch, in theory it's possible to have a file backed backend, for which this can be re-used withposix_fadvise.