-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wip wyoming cli #2853
base: master
Are you sure you want to change the base?
add wip wyoming cli #2853
Conversation
I have confirmed this works in rhasspy/wyoming-whisper-cpp#4 If there is no interest in having it upstream, another option would be to build it as a standalone binary downstream, but I wasn't able to figure out how to reuse the whisper.cpp cmake infrastructure to build an out of tree example with all the right includes and libraries. |
It seems that the new example that you propose is very similar to the existing |
I tried that initially, but the way each chunk of json+wav on stdin is essentially processed as a separate file seemed a bit at odds with how the cli example works. So it seemed simpler to split off the example than to complicate the cli option parsing and main loop. |
I see. I think you can introduce a CLI flag I would like to avoid having a new example that is so similar to an existing one - it will be more difficult to maintain. Let me know if the above propose would work. |
Sure I can give it a go. Another alternative is to just maintain this as part of the python package but I'd have to figure out the build system. I think that might honestly make more sense since it's somewhat coupled. |
Yes, it would make more sense. Note that the example apart from using |
Should fix #2738 once it's tested, polished, and approved
I basically applied https://gist.github.com/jaharon/b18536bd28455ab961ce5e13712f30d9 and deleted all the code for reading and writing various types of files.
So what this does is basically read a wyoming json+wav chunk, and spit out text
Next my plan is to update https://github.com/rhasspy/wyoming-whisper-cpp to build whisper.cpp as a submodule and then test it on my raspberry pi.