ggml-backend : metal #552
Merged
ggml-backend : metal #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than some leftovers from the CPU backend, like the work buffers, plans and |
slaren
reviewed
Oct 5, 2023
src/ggml-metal.m
Outdated
Comment on lines
1430
to
1431
| // TODO: get page size ?? | ||
| //return sysconf(_SC_PAGESIZE); |
There was a problem hiding this comment.
This is the tensor alignment only. I don't think that tensors need to be aligned to pages.
There was a problem hiding this comment.
Ok, I'll clean-up this tomorrow and merge and then we can merge the main PR
ggerganov
force-pushed
the
ggml-backend-metal
branch
from
54a6701 to
9415943
Compare
slaren
added a commit
that referenced
this pull request
Oct 6, 2023
* ggml backends interface v1 * ggml-backend : metal (#552) --------- Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not the best way to implement this, but at least it works