Fix encoding of json keys that contain utf-8 characters #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Bit sad we have to do this, but unless we can differentiate between ObjectValues that originate from custom scalars to those that originate from the schema itself, I can't think of another way. While differentiating is possible, it will make the code more complex and I don't think we should do it simply for improving json encoding performance.
|
@ghostdogpr happy to merge in if you're also happy with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in discord, this PR aims to fix the case where a json key contains UTF-8 characters, which are then not correctly encoded by jsoniter, leading to invalid json in the (http) response.