Skip to content

Commit

Permalink
Change grpc.proto TradeInfo field names
Browse files Browse the repository at this point in the history
- is_fiat_sent		->	is_payment_started_message_sent
	Payment can be in altcoin.
- is_fiat_received	->	is_payment_received_message_sent
	Payment can be in altcoin.
- is_withdrawn		->	is_completed
	Trade can be closed with funds kept in Bisq wallet.
  • Loading branch information
ghubstan committed Feb 27, 2022
1 parent 68ebdb2 commit b9b66b4
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions proto/src/main/proto/grpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -609,16 +609,13 @@ message TradeInfo {
// Whether the trade's security deposit bitcoin transaction has been confirmed at least once, or not.
bool is_deposit_confirmed = 19;
// Whether the trade's 'start payment' message has been sent by the BTC buyer, or not.
// (TODO Rename field to isPaymentSent because payment could be made in altcoin.)
bool is_fiat_sent = 20;
bool is_payment_started_message_sent = 20;
// Whether the trade's 'payment received' message has been sent by the BTC seller, or not.
// (TODO Rename field to isPaymentReceived because payment could be made in altcoin.)
bool is_fiat_received = 21;
bool is_payment_received_message_sent = 21;
// Whether the trade's payout bitcoin transaction has been confirmed at least once, or not.
bool is_payout_published = 22;
// Whether the trade's payout has been completed and the trade is now closed, or not.
// (TODO Rename field to isClosed, or isCompleted because payment could be made in altcoin.)
bool is_withdrawn = 23;
bool is_completed = 23;
// The entire trade contract as a json string.
string contract_as_json = 24;
// The summary of the trade contract.
Expand Down

0 comments on commit b9b66b4

Please sign in to comment.