Use fmt machinery instead of io one #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of a #![no_std] port
|
#![no_std] is needed for gimli-rs/addr2line#89 . |
est31
commented
Jun 4, 2018
src/ast.rs
Outdated
| @@ -6021,7 +6015,8 @@ where | |||
| } else { | |||
| start | |||
| }; | |||
| ctx.write_all(&ctx.input[start..end]) | |||
| let s = ::std::str::from_utf8(&ctx.input[start..end]).map_err(|_| fmt::Error)?; | |||
There was a problem hiding this comment.
Is this .map_err(|_| fmt::Error) okay? I'm doing this in multiple places in this PR. I could also create a custom error type or use the error type from the the error module of this crate (extending it with fmt::Error support previously).
14 tasks
|
@est31 the motivation is that |
|
@fitzgen exactly. We only use |
fitzgen
approved these changes
Jun 4, 2018
src/ast.rs
Outdated
| log_demangle!(self, ctx, scope); | ||
|
|
||
| let leaf = scope | ||
| .leaf_name() | ||
| .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?; | ||
| .map_err(|_| fmt::Error)?; |
There was a problem hiding this comment.
For debuggability, we should do this:
.map_err(|e| {
log!("Error getting leaf name: {}", e);
fmt::Error
})The log! will be a no-op when the logging feature is not enabled.
src/ast.rs
Outdated
| @@ -6021,7 +6015,8 @@ where | |||
| } else { | |||
| start | |||
| }; | |||
| ctx.write_all(&ctx.input[start..end]) | |||
| let s = ::std::str::from_utf8(&ctx.input[start..end]).map_err(|_| fmt::Error)?; | |||
fitzgen
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of a #![no_std] port