Merge pull request #32 from gin-contrib/update_status_code

change status code for invalid key to unauthorized
gin-contrib · Dec 28, 2022 · a3fb6bb · a3fb6bb
2 parents 0c33f40 + f8cd474
commit a3fb6bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/authenticator.go b/authenticator.go
@@ -91,6 +91,10 @@ func (a *Authenticator) Authenticated() gin.HandlerFunc {
 
 		secret, err := a.getSecret(sigHeader.keyID, sigHeader.algorithm)
 		if err != nil {
+			if err == ErrInvalidKeyID {
+				_ = c.AbortWithError(http.StatusUnauthorized, err)
+				return
+			}
 			_ = c.AbortWithError(http.StatusBadRequest, err)
 			return
 		}

diff --git a/authenticator_test.go b/authenticator_test.go
@@ -92,7 +92,7 @@ func TestAuthenticatedHeaderWrongKey(t *testing.T) {
 	req.Header.Set(authorizationHeader, sigHeader)
 	req.Header.Set("Date", time.Now().UTC().Format(http.TimeFormat))
 	c := runTest(secrets, requiredHeaders, nil, req)
-	assert.Equal(t, http.StatusBadRequest, c.Writer.Status())
+	assert.Equal(t, http.StatusUnauthorized, c.Writer.Status())
 	assert.Equal(t, ErrInvalidKeyID, c.Errors[0])
 }