Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset indeterminate state when check-all is changed directly #12

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Reset indeterminate state when check-all is changed directly #12

merged 2 commits into from
Oct 10, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Oct 4, 2019 •
edited
Loading

Whenever check-all checkbox is changed, the result will be all or nothing, so the indeterminate state should be reset.

@muan muan requested a review from a team October 4, 2019 15:26
@muan
Copy link
Contributor Author

muan commented Oct 8, 2019

👋 reviewers, this adds indeterminate state support for programmatic interaction with check-all box.

keithamus
keithamus approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

dgraham
dgraham approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@muan muan merged commit d4f41c0 into master Oct 10, 2019
@muan muan deleted the indeterminate branch October 10, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@dgraham dgraham dgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muan @keithamus @dgraham