Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to keep comments #325

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Make it possible to keep comments #325

merged 1 commit into from
Jun 4, 2022

Conversation

satabin
Copy link
Member

@satabin satabin commented Jun 3, 2022

Comments can be useful to keep when transforming XML from source to
source.

@satabin satabin requested a review from ybasket June 3, 2022 16:15
@satabin satabin added enhancement New feature or request xml labels Jun 3, 2022
@satabin satabin added this to the 1.4.0 milestone Jun 3, 2022
@satabin satabin force-pushed the xml/comments branch 2 times, most recently from b08f72e to c5867f2 Compare June 3, 2022 17:19
Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on naming, apart from that it looks good!

Comments can be useful to keep when transforming XML from source to
source.
@satabin satabin merged commit 992f2ec into main Jun 4, 2022
@satabin satabin deleted the xml/comments branch June 4, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request xml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants