-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accept
when crossing chunk boundary
#335
Conversation
Looping on `accept` instead of `loop` restarts reading the string to accept from the beginning, which results in wrongly reported syntax error.
I believe this was @rossabaker's 🔎 🐛 but 🎉 all the same! :) |
You’re right, sorry for the mis-attribution. |
It looks like since upgrading fs2, Scala.JS tests are a bit flaky.
Wooops! Can you point me to something specific? I did a big refactor of the internal implementation and probably introduced some bugs 😓 |
I was about to ping you 😅 |
Oh dear, thanks, that looks pretty ominous 😱 let's see if I can at least replicate it locally. |
@armanbilge it looks like downgrading did the trick. I will release a bugfix release with it. If you need more inputs on my problems, let me know. |
Looping on
accept
instead ofloop
restarts reading the string toaccept from the beginning, which results in wrongly reported syntax
error.
Thanks @rossabaker for spotting this bug.