-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile most modules with Scala Native #384
Conversation
a3d3bdb
to
e2fdb58
Compare
Failing on Scala 3 because Play! JSON isn't available there yet via Diffson (to be fixed with gnieh/diffson#303), works with locally published build. Other than that, this PR is close to being ready. |
jsonPlay.jvm, | ||
jsonPlay.js, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact they were missing didn't seem to bother anyone, the only published version was 1.3.0: https://mvnrepository.com/artifact/org.gnieh/fs2-data-json-play
Trying to fix this now within this PR by releasing full Diffson support.
I'm in favour of dropping support in v2, that library seems rather dead and the code we maintain is so small that it could easily be inlined in users' projects.
@@ -18,10 +18,9 @@ package fs2.data.csv | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to fix compiler warnings from 3.2.0.
Only Play JSON is missing as there isn't any artifact.
Especially sbt-scalajs needed an update.
Had to adjust some Java Time related tests slightly as we don't have a proper timezone DB on native, but other than that, it was very easy.
Diffson needs to be cross-compiled first to unblock the other modules, looking into that.Closes #376.