Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile most modules with Scala Native #384

Merged
merged 14 commits into from
Oct 5, 2022
Merged

Compile most modules with Scala Native #384

merged 14 commits into from
Oct 5, 2022

Conversation

ybasket
Copy link
Collaborator

@ybasket ybasket commented Sep 19, 2022

Had to adjust some Java Time related tests slightly as we don't have a proper timezone DB on native, but other than that, it was very easy. Diffson needs to be cross-compiled first to unblock the other modules, looking into that.

Closes #376.

@ybasket ybasket force-pushed the scala-native branch 2 times, most recently from a3d3bdb to e2fdb58 Compare September 20, 2022 14:45
@ybasket
Copy link
Collaborator Author

ybasket commented Oct 2, 2022

Failing on Scala 3 because Play! JSON isn't available there yet via Diffson (to be fixed with gnieh/diffson#303), works with locally published build.

Other than that, this PR is close to being ready.

Comment on lines +177 to +180
jsonPlay.jvm,
jsonPlay.js,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact they were missing didn't seem to bother anyone, the only published version was 1.3.0: https://mvnrepository.com/artifact/org.gnieh/fs2-data-json-play

Trying to fix this now within this PR by releasing full Diffson support.

I'm in favour of dropping support in v2, that library seems rather dead and the code we maintain is so small that it could easily be inlined in users' projects.

@@ -18,10 +18,9 @@ package fs2.data.csv

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to fix compiler warnings from 3.2.0.

@ybasket ybasket marked this pull request as ready for review October 3, 2022 13:39
@ybasket ybasket requested a review from satabin October 3, 2022 13:39
@ybasket ybasket changed the base branch from main to series/1.5.x October 3, 2022 18:03
@ybasket ybasket closed this Oct 5, 2022
@ybasket ybasket reopened this Oct 5, 2022
@ybasket ybasket merged commit 5b2e58a into series/1.5.x Oct 5, 2022
@ybasket ybasket deleted the scala-native branch October 5, 2022 11:15
@ybasket ybasket mentioned this pull request Oct 5, 2022
@satabin satabin added enhancement New feature or request infrastructure labels Oct 27, 2022
@satabin satabin added this to the 1.6.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala Native
2 participants