Compile most modules with Scala Native #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybasket
force-pushed
the
scala-native
branch
2 times, most recently
from
a3d3bdb to
e2fdb58
Compare
|
Failing on Scala 3 because Play! JSON isn't available there yet via Diffson (to be fixed with gnieh/diffson#303), works with locally published build. Other than that, this PR is close to being ready. |
ybasket
commented
Oct 2, 2022
Comment on lines
+177
to
+180
| jsonPlay.jvm, | ||
| jsonPlay.js, |
There was a problem hiding this comment.
The fact they were missing didn't seem to bother anyone, the only published version was 1.3.0: https://mvnrepository.com/artifact/org.gnieh/fs2-data-json-play
Trying to fix this now within this PR by releasing full Diffson support.
I'm in favour of dropping support in v2, that library seems rather dead and the code we maintain is so small that it could easily be inlined in users' projects.
ybasket
commented
Oct 2, 2022
| @@ -18,10 +18,9 @@ package fs2.data.csv | |||
|
|
|||
There was a problem hiding this comment.
Changes to fix compiler warnings from 3.2.0.
Only Play JSON is missing as there isn't any artifact.
Especially sbt-scalajs needed an update.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to adjust some Java Time related tests slightly as we don't have a proper timezone DB on native, but other than that, it was very easy.
Diffson needs to be cross-compiled first to unblock the other modules, looking into that.Closes #376.