Fix XML rendering #385
Merged
Fix XML rendering #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satabin
approved these changes
Oct 4, 2022
ybasket
commented
Oct 4, 2022
| def render[F[_]](collapseEmpty: Boolean = true): Pipe[F, XmlEvent, String] = | ||
| _.zipWithPrevious.map { | ||
| case (_, st: XmlEvent.StartTag) => st.render(collapseEmpty) | ||
| case (Some(XmlEvent.StartTag(_, _, true)), XmlEvent.EndTag(_)) if collapseEmpty => "" |
There was a problem hiding this comment.
@satabin Just confirming: It is correct that we emit an EndTag after a StartTag with isEmpty=true, right?
So <doc/> would lead to Lis(StartTag("doc", Nil, true), EndTag("doc")).
Fix buggy Show instance for XmlEvent and provide a pipe to render events with collapsed empty tags.
ybasket
force-pushed
the
fix/xml-rendering
branch
from
3dd4d2c to
10d2f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix buggy Show instance for XmlEvent and provide a pipe to render events with collapsed empty tags.