Remove setup-gpg, refresh release workflow #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satabin
approved these changes
Oct 5, 2022
keynmol
reviewed
Oct 5, 2022
| with: | ||
| fetch-depth: 0 | ||
| - uses: olafurpg/setup-scala@v10 | ||
| - uses: olafurpg/setup-gpg@v3 | ||
| - uses: olafurpg/setup-scala@v13 |
There was a problem hiding this comment.
Btw, Olaf's setup-scala is being deprecated.
I'd recommend using builtin actions/setup-java (explicitly setting java version to whatever your target is) which already comes with both sbt and sbt cache configuration
There was a problem hiding this comment.
Thanks for the hint! I'm aware of the deprecation, but don't want to change much on what was supposed to be a "simple" patch release. #315 would be something I want to get over the finish line, especially now with the native support included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes the problem we have with releasing.