Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup-gpg, refresh release workflow #388

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

ybasket
Copy link
Collaborator

@ybasket ybasket commented Oct 5, 2022

Hopefully fixes the problem we have with releasing.

@ybasket ybasket merged commit 7a5abd0 into series/1.5.x Oct 5, 2022
@ybasket ybasket deleted the feature/remove-setup-gpg branch October 5, 2022 12:52
with:
fetch-depth: 0
- uses: olafurpg/setup-scala@v10
- uses: olafurpg/setup-gpg@v3
- uses: olafurpg/setup-scala@v13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, Olaf's setup-scala is being deprecated.
I'd recommend using builtin actions/setup-java (explicitly setting java version to whatever your target is) which already comes with both sbt and sbt cache configuration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint! I'm aware of the deprecation, but don't want to change much on what was supposed to be a "simple" patch release. #315 would be something I want to get over the finish line, especially now with the native support included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants