Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty csv cell strings in generic derivation #391

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

ybasket
Copy link
Collaborator

@ybasket ybasket commented Oct 7, 2022

Was probably meant as an optimization, but there empty strings can be legitimate. Users can still require non-emptiness using a cell decoder or by parsing into Option.

Was probably meant as an optimization, but there empty strings can be legitimate. Users can still require non-emptiness using a cell decoder or by parsing into Option.
@ybasket ybasket requested a review from satabin October 7, 2022 07:43
@satabin satabin added this to the 1.6.0 milestone Oct 8, 2022
@satabin satabin added enhancement New feature or request csv labels Oct 8, 2022
@satabin satabin merged commit 92dcb60 into main Oct 8, 2022
@satabin satabin deleted the fix/allow-empty-cell-strings branch October 8, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csv enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants