Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up type params #409

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Clean up type params #409

merged 1 commit into from
Oct 27, 2022

Conversation

ybasket
Copy link
Collaborator

@ybasket ybasket commented Oct 24, 2022

Turns out we don't have to track the type of the case class we're deriving for while deriving the corresponding HList codec. MiMa seems happy as the only changes are type parameters and I don't expect users to ever call the affected methods from their code, so it's source-compatible.

Turns out we don't have to track the type of the case class we're deriving for while deriving the corresponding HList codec. MiMa seems happy as the only changes are type parameters and I don't expect users to ever call the affected methods from their code, so it's source-compatible.
@ybasket ybasket requested a review from a team as a code owner October 24, 2022 17:59
@ybasket ybasket added this to the 1.6.0 milestone Oct 24, 2022
@satabin satabin merged commit 60c7dfc into main Oct 27, 2022
@satabin satabin deleted the feature/cleanup-csv-type-params branch October 27, 2022 09:02
@satabin satabin added enhancement New feature or request csv labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csv enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants