Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize optional fields handling for RowF #459

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Conversation

satabin
Copy link
Member

@satabin satabin commented Mar 10, 2023

An optional field might be encoded in various ways, depending on the CSV data emitter. RowF can handle most scenarios by providing a way to define:

  • how to react when a field is not present in the dataset at all (i.e. the column is missing in the input data)
  • what values are considered empty (e.g. empty string, or null, or N/A)

@satabin satabin added enhancement New feature or request csv labels Mar 10, 2023
@satabin satabin added this to the 1.7.0 milestone Mar 10, 2023
@satabin satabin requested a review from a team as a code owner March 10, 2023 17:07
@satabin satabin force-pushed the csv/optional-values branch from 4680aad to a6ae205 Compare March 10, 2023 17:09
satabin added 2 commits March 10, 2023 18:12
An optional field might be encoded in various ways, depending on the CSV
data emitter. `RowF` can handle most scenarios by providing a way to
define:
 - how to react when a field is not present in the dataset at all (i.e.
   the column is missing in the input data)
 - what values are considered empty (e.g. empty string, or `null`, or
   `N/A`)
@satabin satabin force-pushed the csv/optional-values branch 3 times, most recently from 7355537 to 72e5bfb Compare March 10, 2023 17:24
Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satabin satabin force-pushed the csv/optional-values branch from dcb410d to 4612674 Compare March 10, 2023 17:38
@satabin satabin force-pushed the csv/optional-values branch from 4612674 to 95e54dc Compare March 10, 2023 17:40
@satabin satabin merged commit edea722 into main Mar 10, 2023
@satabin satabin deleted the csv/optional-values branch March 10, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csv enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants