Indexing CMM brackets #69
Conversation
| type FleetDeployed @entity { | ||
| id: ID! # txHash + id | ||
| owner: Bytes! | ||
| fleet: [Bytes!] |
There was a problem hiding this comment.
probably you want to map here an array of other entities, right?
There was a problem hiding this comment.
The fleet is really just a gnosis-safe address. At the time of FleetDeployment, there is no additional data available. Only later it would be good to have for each fleet also the orders and balances, but I guess this is done the best within the actual query, as orders and balances are well defined in the graph,
There was a problem hiding this comment.
If the fleet will have fields in the future (like, orders, trades, balances, and so on) you should model it as an entity in my opinion.
under the hood, the graph saves the fleet id, that can still be the address, but it's just a better approach to try to model your entities since the begining
| fleet: [Bytes!] | ||
|
|
||
| # Transaction | ||
| txHash: Bytes! |
There was a problem hiding this comment.
Look in other entities, it's nice to have audit times too
There was a problem hiding this comment.
Actually, the deployment of fleet-safe contracts will not be relevant at all. Only the placement of the orders will have any meaning in all use cases, which I can imagine.
There was a problem hiding this comment.
why is not relevant?
is not relevant for the date and tx when it was deployed?
There was a problem hiding this comment.
Looking at the CMM data requirements (gnosis/safe-cmm-app-react#9), specifically the fact that token pair and amount is needed, I wonder if it would make sense to add that data to the event that gets indexed here (and load from Deposit events).
Or is this very involved and better to do two roundtrips:
- to get the tx hash/addresses of the FleetDeployed event
- Query deposits of those addresses at the given tx hash.
|
Currently, the fleetdeployment, ordersetting and transferApproveDeposits are happing in a separate transaction and hence, I think they need to be indexed separately and we have to go the roundtrips. But, @andre-meyer told me yesterday, that this several step process is a huge issue for the gnosis safe. Maybe we would be quicker, if we would do all interaction(fleetdeployment, orderplacement and depositing) in one transaction. I will discuss it with him |
|
I'm not super aware of the scripts/model. In my opinion, it will help, both the design and the review, if you can write some UML with the entities and their relations. I see we are not using the entities we have already defined. Otherwise, if we see is better to have it separated, we can make it as an independent subgraph |
This PR makes sure that the basic Fleet deployments are indexed.
A later PR will index more information, which will allow more advanced queries like getting the bracket-strategy price span.
Testplan:
Run through the steps of the Readme
and then check that you see the 1 strategy with 2 brackets deployed on your localhost with this query: