Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry on alreadyReplaced error #2475

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix: retry on alreadyReplaced error #2475

merged 1 commit into from
Mar 12, 2025
+30 −3

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 9, 2025 •
edited
Loading

@ldez ldez added bug area/ari ACME Renewal Information Extension labels Mar 9, 2025
@ldez ldez added this to the unreleased milestone Mar 9, 2025
@ldez ldez requested a review from dmke March 9, 2025 15:43
@ldez
Copy link
Member Author

ldez commented Mar 9, 2025 •
edited
Loading

I have a problem: the RFC is talking about alreadyReplaced type

But Boulder has no reference of that: alreadyReplaced

letsencrypt/boulder#7385

And Pebble has also no reference: Conflict

Also, the type inside the issue is urn:ietf:params:acme:error:conflict and not urn:ietf:params:acme:error:alreadyReplaced.

So I don't know if I should follow the RFC.

@dmke WDYT?

@ldez
Copy link
Member Author

ldez commented Mar 9, 2025

Maybe @beautifulentropy could help us in this context?

@dmke
Copy link
Member

dmke commented Mar 9, 2025

Hm. I need to think about that a bit.

My gut feeling says go with the standard (even though it's still a draft).

@beautifulentropy
Copy link
Contributor

beautifulentropy commented Mar 10, 2025 •
edited
Loading

@dmke @ldez Thanks for bringing this to my attention. It appears that we've dropped the ball here, I'll see about getting a PR out to fix this issue in Boulder and ensure that we reference this PR.

@beautifulentropy beautifulentropy mentioned this pull request Mar 10, 2025
Merged
@beautifulentropy
Copy link
Contributor

The aforementioned PR has been merged and should go to production next week. Thanks again for letting us know!

@ldez
Copy link
Member Author

ldez commented Mar 12, 2025

Thank you!
We will merge the PR, now we know we should follow the RFC.

@ldez ldez merged commit a8693c1 into go-acme:master Mar 12, 2025
7 checks passed
@ldez ldez deleted the fix/ari-alreadyReplaced branch March 12, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/ari ACME Renewal Information Extension bug
Milestone
unreleased
Development

Successfully merging this pull request may close these issues.

cannot indicate an order replaces certificate with serial <serial>, which already has a replacement order
3 participants
@ldez @dmke @beautifulentropy