Check issue labels slice length before calling xorm Insert; fixes #20654

(#20655) Co-authored-by: 6543 <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>
go-gitea · Aug 4, 2022 · 6c218f7 · 6c218f7
1 parent b6bb389
commit 6c218f7
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/services/repository/template.go b/services/repository/template.go
@@ -23,6 +23,11 @@ func GenerateIssueLabels(ctx context.Context, templateRepo, generateRepo *repo_m
 	if err != nil {
 		return err
 	}
+	// Prevent insert being called with an empty slice which would result in
+	// err "no element on slice when insert".
+	if len(templateLabels) == 0 {
+		return nil
+	}
 
 	newLabels := make([]*issues_model.Label, 0, len(templateLabels))
 	for _, templateLabel := range templateLabels {