Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error pagination on Adopt repositories admin page #14111

Closed
1 of 6 tasks
camlafit opened this issue Dec 22, 2020 · 1 comment · Fixed by #14133
Closed
1 of 6 tasks

Error pagination on Adopt repositories admin page #14111

camlafit opened this issue Dec 22, 2020 · 1 comment · Fixed by #14133
Labels
type/bug

Comments

@camlafit
Copy link
Contributor

  • Gitea version (or commit ref): 1.13.0
  • Git version:
  • Operating system: Debian
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:
    Not relevant

Description

On /admin/repos/unadopted?search=true&q= pagination doesn't work. Only first page propose abandonned repository.

I presume it's related to #12920

Screenshots

Capture d’écran de 2020-12-22 15-46-52
Capture d’écran de 2020-12-22 15-47-00
@noerw noerw added the type/bug label Dec 22, 2020
@zeripath
Copy link
Contributor

The problem is that the page turns are missing the search=true parameter

zeripath added a commit to zeripath/gitea that referenced this issue Dec 23, 2020
@zeripath
Ensure that search term and page are not lost on adoption page-turn
52cbb5a 
Fix go-gitea#14111

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Dec 23, 2020
Merged
lunny added a commit that referenced this issue Dec 24, 2020
@zeripath @lunny
Ensure that search term and page are not lost on adoption page-turn (#…
fa2e349 
…14133)

Fix #14111

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this issue Dec 24, 2020
@zeripath
Ensure that search term and page are not lost on adoption page-turn (g…
3695f16 
…o-gitea#14133)

Backport go-gitea#14133

Fix go-gitea#14111

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Dec 24, 2020
Merged
zeripath added a commit that referenced this issue Dec 24, 2020
@zeripath
Ensure that search term and page are not lost on adoption page-turn (#…
bf1441b 
…14133) (#14143)

Backport #14133

Fix #14111

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that search term and page are not lost on adoption page-turn zeripath/gitea
3 participants
@camlafit @zeripath @noerw