Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email addresses not rendered as such if followed by punctuation (except full stop) #27616

Closed
nschloe opened this issue Oct 14, 2023 · 0 comments · Fixed by #27987
Closed

Email addresses not rendered as such if followed by punctuation (except full stop) #27616

nschloe opened this issue Oct 14, 2023 · 0 comments · Fixed by #27987
Labels
type/bug

Comments

@nschloe
Copy link

nschloe commented Oct 14, 2023

Description

MWE:

[email protected],
[email protected].
[email protected];
[email protected]?
[email protected]!

Gitea Version

1.22.0+dev-181-g76a85a4ce

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

screenshot_2023-10-14-140530

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io/

Database

None
@nschloe nschloe mentioned this issue Oct 30, 2023
Open
@yardenshoham yardenshoham mentioned this issue Nov 10, 2023
Merged
6543 pushed a commit that referenced this issue Nov 11, 2023
@yardenshoham
Render email addresses as such if followed by punctuation (#27987)
1c0566f 
Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes #27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
@GiteaBot GiteaBot mentioned this issue Nov 11, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 11, 2023
@yardenshoham @GiteaBot
Render email addresses as such if followed by punctuation (go-gitea#2…
336d274 
…7987)

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes go-gitea#27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
@GiteaBot GiteaBot mentioned this issue Nov 11, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 11, 2023
@yardenshoham @GiteaBot
Render email addresses as such if followed by punctuation (go-gitea#2…
ae01bb9 
…7987)

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes go-gitea#27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
lunny pushed a commit that referenced this issue Nov 11, 2023
@GiteaBot @yardenshoham
Render email addresses as such if followed by punctuation (#27987) (#…
2691b34 
…27992)

Backport #27987 by @yardenshoham

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes #27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Yarden Shoham <[email protected]>
lunny pushed a commit that referenced this issue Nov 11, 2023
@GiteaBot @yardenshoham
Render email addresses as such if followed by punctuation (#27987) (#…
dfd960f 
…27991)

Backport #27987 by @yardenshoham

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes #27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Yarden Shoham <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@yardenshoham @fuxiaohei
Render email addresses as such if followed by punctuation (go-gitea#2…
2120fbb 
…7987)

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes go-gitea#27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@yardenshoham @silverwind
Render email addresses as such if followed by punctuation (go-gitea#2…
e2915a6 
…7987)

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes go-gitea#27616 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@GiteaBot @earl-warren
Render email addresses as such if followed by punctuation (go-gitea#2…
1bbc1ad 
…7987) (go-gitea#27991)

Backport go-gitea#27987 by @yardenshoham

Added the following characters to the regular expression for the email:

- ,
- ;
- ?
- !

Also added a test case.

- Fixes go-gitea#27616

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af)

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Yarden Shoham <[email protected]>
(cherry picked from commit dfd960f)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render email addresses as such if followed by punctuation yardenshoham/gitea
1 participant
@nschloe