-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect API response for repositories without avatar #31167
Comments
Regression from #30885 maybe? |
lunny
pushed a commit
that referenced
this issue
Jun 1, 2024
) Resolves #31167. #30885 changed the behavior of `repo.AvatarLink()` where it can now take the empty string and append it to the app data URL. This does not point to a valid avatar image URL, and, as the issue mentions, previous Gitea versions returned the empty string. --------- Co-authored-by: wxiaoguang <[email protected]>
Still broken in recently released 1.22.1, missing backport? |
jpraet
pushed a commit
to jpraet/gitea
that referenced
this issue
Jul 5, 2024
…gitea#31187) Backport go-gitea#31187 Resolves go-gitea#31167. go-gitea#30885 changed the behavior of `repo.AvatarLink()` where it can now take the empty string and append it to the app data URL. This does not point to a valid avatar image URL, and, as the issue mentions, previous Gitea versions returned the empty string. --------- Co-authored-by: wxiaoguang <[email protected]>
6543
pushed a commit
that referenced
this issue
Jul 5, 2024
) (#31567) Backport #31187 Resolves #31167. #30885 changed the behavior of `repo.AvatarLink()` where it can now take the empty string and append it to the app data URL. This does not point to a valid avatar image URL, and, as the issue mentions, previous Gitea versions returned the empty string. Co-authored-by: Kemal Zebari <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Backported |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
For repositories without an avatar, we now get this in the API response:
"avatar_url": "https://demo.gitea.com/"
In 1.21 this was
"avatar_url": ""
Gitea Version
1.23.0+dev-151-gc93cbc991e
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
docker
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: