-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't manipulate input params in email notification #16011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16011 +/- ##
==========================================
- Coverage 44.07% 44.06% -0.02%
==========================================
Files 682 682
Lines 82389 82394 +5
==========================================
- Hits 36312 36303 -9
- Misses 40177 40190 +13
- Partials 5900 5901 +1
Continue to review full report at Codecov.
|
lunny
approved these changes
May 29, 2021
a1012112796
approved these changes
May 29, 2021
jpraet
added a commit
to jpraet/gitea
that referenced
this pull request
May 30, 2021
techknowlogick
pushed a commit
that referenced
this pull request
May 31, 2021
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15993
In some email notifications the content of the input model object is set to empty string "".
But this affects the other notification services, for example causing the content to also be empty in the webhook payloads.
Instead of directly manipulating the input object, the empty content is now passed mailCommentContext.