-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commits dropdown in PR files view and allow commit by commit review #25528
Merged
delvh
merged 88 commits into
go-gitea:main
from
sebastian-sauer:feature/allow_review_commit_by_commit
Jul 28, 2023
Merged
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
acbd8dd
Add commits dropdown in PR files view
sebastian-sauer bd1551c
Disable File-Viewed when reviewing a single commit
sebastian-sauer 862ffc8
Add ellipsis and divider
sebastian-sauer 836ee9b
Add styles and ellipsis
sebastian-sauer 77a81bb
Add max-height and scroll for list of commits
sebastian-sauer 45b7567
Update web_src/css/repo.css
silverwind a763afe
Reduce padding of commit-menu
sebastian-sauer a63c7b9
ui enhancements
silverwind eaa02c7
add jump class to correctly hide tippy
silverwind bfab42b
tweak locale
silverwind b390786
remove unnecessary display
silverwind d439c1f
reduce height some more for small screens
silverwind 2f275a6
calculate len only once
silverwind 9653f1a
Check if given commit sha exists on this PR
sebastian-sauer 7049c71
Improve code
sebastian-sauer f45980b
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer 5b8b4cb
Support three github urls
sebastian-sauer 971d0a0
Make uris behave like github
sebastian-sauer 059c55b
Make commit selector a vue component
sebastian-sauer 1991bf8
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer 4d1a4bf
Improve var naming and add comments
sebastian-sauer 451f644
Fix displayed commit for single commits
sebastian-sauer 2d4accf
Disable submitting review when not viewing the full diff
sebastian-sauer c60b78f
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer 0e105bb
Add integration tests for different PR diff endpoints
sebastian-sauer 563d371
fix fmt
sebastian-sauer 0328434
Merge branch 'main' into feature/allow_review_commit_by_commit
sebastian-sauer 6d6d846
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer 8588935
Add integration test with more commits
sebastian-sauer 36f3af2
Remove button loading artifacts until vue component is loaded
sebastian-sauer 91217eb
Add comment explaining why the svg is available
sebastian-sauer 43a8a15
Fix integration tests
sebastian-sauer 6828bfd
Add "Show changes since your last review" functionality
sebastian-sauer 863edf6
Add missing divider
sebastian-sauer 076c5ee
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer ea83620
Fix lint
sebastian-sauer 2b37ae4
Fix more tests
sebastian-sauer 1824329
Fix fixture
sebastian-sauer 9dde031
Merge branch 'main' into feature/allow_review_commit_by_commit
sebastian-sauer ad226d7
Update web_src/js/components/DiffCommitSelector.vue
silverwind 60e1e53
Fix ci error
sebastian-sauer 9a3fe9c
lowercase json keys
sebastian-sauer 5cf8473
Merge branch 'feature/allow_review_commit_by_commit' of https://githu…
sebastian-sauer 1590ad5
Use frontend fetch to get the data
sebastian-sauer d2b065a
Fix changes since last review url
sebastian-sauer 109394c
Fix order of commits
sebastian-sauer bcb7c09
Refactors and add hint for commit range
sebastian-sauer 429e41f
Add missing translation
sebastian-sauer 0aef59c
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer 5fc1492
Merge branch 'main' into feature/allow_review_commit_by_commit
sebastian-sauer 08094a0
Apply suggestions from code review
sebastian-sauer 333ae56
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer ec0f21c
Add loading animation
sebastian-sauer ba32e3d
Merge branch 'main' into feature/allow_review_commit_by_commit
silverwind fea2a66
Use ShortSha for UI
sebastian-sauer 7518ec1
Add max-width and fix double border-top
sebastian-sauer 91a6d0d
Merge branch 'feature/allow_review_commit_by_commit' of https://githu…
sebastian-sauer f3895a1
Merge branch 'main' into feature/allow_review_commit_by_commit
silverwind bbf9676
css tweaks
silverwind dcbdb2e
Fix committer display in vue component
sebastian-sauer 34c9154
Merge branch 'main' into feature/allow_review_commit_by_commit
sebastian-sauer 8307701
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer 8a7c4a1
Merge branch 'feature/allow_review_commit_by_commit' of https://githu…
sebastian-sauer fe0e4c9
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer e005ee3
Fix case of PR
sebastian-sauer 243ade4
Remove div selector
sebastian-sauer 1018cfd
Improve check for empty last review commit ha
sebastian-sauer 78b1006
Improve check for empty commit sha
sebastian-sauer 21f9407
Improve routes
sebastian-sauer 92e9a47
Show all changes in PR if all commits are selected
sebastian-sauer feba85a
Fix opening the popup when pressing enter
sebastian-sauer 754d242
Extract logic to services
sebastian-sauer bf424e3
Fix lint
sebastian-sauer c57289e
Fix relative-time in Firefox
sebastian-sauer 9d025f4
Use light color for show all commits message
sebastian-sauer 2d6c974
Disable Changes since last review if no new commits are available
sebastian-sauer 359a3df
Merge remote-tracking branch 'origin/main' into feature/allow_review_…
sebastian-sauer 985d9de
Make dropdown usable with keyboard
sebastian-sauer 1724181
Add "Show All commits" link
sebastian-sauer f7acf4a
Add improved range selection
sebastian-sauer 3f9749f
fix XORM bug
wxiaoguang 5e3df0e
fine tune
wxiaoguang e352233
fine tune
wxiaoguang 57f4864
refactor dom event listener
wxiaoguang 39b4d0c
Merge branch 'main' into feature/allow_review_commit_by_commit
GiteaBot 59588a5
Merge branch 'main' into feature/allow_review_commit_by_commit
GiteaBot 275750e
Merge branch 'main' into feature/allow_review_commit_by_commit
delvh f4438d1
Fix indentation
sebastian-sauer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm… Somehow this line lost half of its indentation in the merge.