Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete repos of org when purge delete user (#27273) #27728

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Delete repos of org when purge delete user (#27273) #27728

merged 8 commits into from
Nov 1, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 22, 2023

@JakobDev @6543
Delete repos of org when purge delete user (go-gitea#27273)
91dce87 
Fixes https://codeberg.org/forgejo/forgejo/issues/1514

I had to remove `RenameOrganization` to avoid circular import.

We should really add some foreign keys to the database.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 22, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 22, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2023
@6543 6543 added the type/bug label Oct 22, 2023
@6543 6543 mentioned this pull request Oct 22, 2023
Merged
@6543 6543 requested a review from a team October 22, 2023 12:53
@denyskon denyskon added modifies/api This PR adds API routes or modifies them and removed kind/api labels Oct 22, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 22, 2023
@6543
Copy link
Member Author

6543 commented Oct 22, 2023

Hmm there might be more to backport if unittest fails again :/

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 22, 2023
@delvh delvh removed the kind/api label Oct 22, 2023
@lunny
Copy link
Member

lunny commented Oct 25, 2023

CI still failed.

@KazzmanK
Copy link
Contributor

Should someone extend timeout for unit tests ?
panic: test timed out after 20m0s

@KN4CK3R
Copy link
Member

KN4CK3R commented Oct 26, 2023

Unit tests should be fast. 20 Minutes is considerably too long.

@KazzmanK
Copy link
Contributor

Failing commit missing
ok code.gitea.io/gitea/routers/web/repo 8.126s coverage: 5.3% of statements
Also
ok code.gitea.io/gitea/routers/web/repo 11.541s coverage: 5.3% of statements
11 seconds instead of 3 on previous commits

Longest test is 2 minutes long
ok code.gitea.io/gitea/modules/auth/password/hash 120.923s coverage: 81.0% of statements

20 minutes of purge user seems to be a kind of infinite cycle or really big job.

@silverwind
Copy link
Member

Longest test is 2 minutes long

This seems ripe for a refactor to speed it up.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 1, 2023
@lunny lunny merged commit 6637bbf into go-gitea:release/v1.21 Nov 1, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 1, 2023
@6543 6543 deleted the backport_27273 branch November 1, 2023 02:09
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@kerwin612 kerwin612 kerwin612 approved these changes

@puni9869 puni9869 puni9869 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.