Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links in docs #28302

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Fix links in docs #28302

merged 8 commits into from
Dec 1, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Nov 30, 2023 •
edited
Loading

Close #28287

How to test it in local

convert Makefile L34 into:

cd .tmp/upstream-docs && git clean -f && git reset --hard && git fetch origin pull/28302/head:pr28302 && git switch pr28302

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 30, 2023
yp05327
yp05327 commented Nov 30, 2023
View reviewed changes
docs/content/installation/from-binary.zh-cn.md
@@ -209,6 +209,6 @@ remote: ./hooks/pre-receive.d/gitea: line 2: [...]: No such file or directory

如果您没有使用 Gitea 内置的 SSH 服务器，您还需要通过在管理选项中运行任务 `Update the '.ssh/authorized_keys' file with Gitea SSH keys.` 来重新编写授权密钥文件。

> 更多经验总结，请参考英文版 [Troubleshooting](/en-us/install-from-binary/#troubleshooting)
Copy link
Contributor Author

@yp05327 yp05327 Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this translation is not good. Are there any way to generate links for other language with same version?

@yp05327
Copy link
Contributor Author

yp05327 commented Nov 30, 2023

image
Awesome is not related. Only one issue mentioned above should be fixed.

@lng2020
Copy link
Member

lng2020 commented Dec 1, 2023

title: "Fix docs" -> "Fix links in docs"?

@yp05327 yp05327 changed the title Fix docs Fix links in docs Dec 1, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Dec 1, 2023

title: "Fix docs" -> "Fix links in docs"?

Done.

@yp05327 yp05327 marked this pull request as ready for review December 1, 2023 02:45
@yp05327 yp05327 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 1, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 1, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 1, 2023
@KN4CK3R KN4CK3R added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 1, 2023
@lunny lunny merged commit 1ae33e0 into go-gitea:main Dec 1, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 1, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 1, 2023
@yp05327 yp05327 deleted the fix-docs-again branch December 3, 2023 23:44
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 4, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d5beeff 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix missing issue search index update when changing status (go-gitea#28325)
  Keep profile tab when clicking on Language (go-gitea#28320)
  Fix wrong link in `protect_branch_name_pattern_desc` (go-gitea#28313)
  Fix links in docs (go-gitea#28302)
@yp05327
Copy link
Contributor Author

yp05327 commented Dec 6, 2023 •
edited
Loading

Backport?
image
https://gitea.com/gitea/gitea-docusaurus/actions/runs/736#jobstep-9-81

@yp05327
Copy link
Contributor Author

yp05327 commented Dec 8, 2023

@lunny

@yp05327 yp05327 mentioned this pull request Dec 11, 2023
Merged
@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.20 This PR should be backported to Gitea 1.20 labels Dec 11, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Dec 11, 2023

It seems that the bot won't work.
How to let bot work manually? 🤔

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 11, 2023
@yp05327 @GiteaBot
Fix links in docs (go-gitea#28302)
ee2257c 
Close go-gitea#28287

## How to test it in local
convert Makefile L34 into:
```
cd .tmp/upstream-docs && git clean -f && git reset --hard && git fetch origin pull/28302/head:pr28302 && git switch pr28302
```
@GiteaBot GiteaBot mentioned this pull request Dec 11, 2023
Merged
lunny pushed a commit that referenced this pull request Dec 11, 2023
@GiteaBot @yp05327
Fix links in docs (#28302) (#28418)
40d5118 
Backport #28302 by @yp05327

Close #28287

## How to test it in local
convert Makefile L34 into:
```
cd .tmp/upstream-docs && git clean -f && git reset --hard && git fetch origin pull/28302/head:pr28302 && git switch pr28302
```

Co-authored-by: yp05327 <[email protected]>
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @yp05327, please send one manually. 🍵

go run ./contrib/backport 28302
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Dec 11, 2023
@lunny lunny added the backport/done All backports for this PR have been created label Dec 11, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Dec 12, 2023

emmm, where is the backport for v1.20?

@lunny
Copy link
Member

lunny commented Dec 12, 2023

emmm, where is the backport for v1.20?

The teabot backport it to v1.20 failed.

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@yp05327 @fuxiaohei
Fix links in docs (go-gitea#28302)
6800188 
Close go-gitea#28287

## How to test it in local
convert Makefile L34 into:
```
cd .tmp/upstream-docs && git clean -f && git reset --hard && git fetch origin pull/28302/head:pr28302 && git switch pr28302
```
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@yp05327 @silverwind
Fix links in docs (go-gitea#28302)
a1cd78d 
Close go-gitea#28287

## How to test it in local
convert Makefile L34 into:
```
cd .tmp/upstream-docs && git clean -f && git reset --hard && git fetch origin pull/28302/head:pr28302 && git switch pr28302
```
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Broken links in docs
5 participants
@yp05327 @lng2020 @GiteaBot @lunny @KN4CK3R