Update generate-images dependencies and rebuild #30689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
approved these changes
Apr 25, 2024
GiteaBot
added
lgtm/need 1
|
Please see #30685 (comment). |
wxiaoguang
approved these changes
Apr 25, 2024
GiteaBot
added
lgtm/done
|
Yes, I do have a branch for splitting tool deps into a separate package.json/package-lock.json in silverwind@85090d3, but currently I'm a bit conflicted whether it's worth all the additional complexity, so I have not raised it yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
generate-images.json v1.21 to the latest version from main branch and I ran it which generated some minor diff in the SVGs. It fixes one issue mentioned in #30596 (comment) by removing--no-package-lock.