Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show passkey on http sites #33820

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Do not show passkey on http sites #33820

merged 2 commits into from
Mar 7, 2025
+10 −1

Conversation

wxiaoguang
Copy link
Contributor

Fix #33615

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 7, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 7, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 7, 2025
Closed
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 labels Mar 7, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 7, 2025
Merged
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Mar 7, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 7, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 7, 2025
ChristopherHX
ChristopherHX approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both http localhost (visible) and something else on http (no error, no webauthn) are working for me, looks much better now without the error ❤️

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2025
lafriks pushed a commit that referenced this pull request Mar 7, 2025
@wxiaoguang @yp05327
Support disable passkey auth (#33348) (#33819)
d03e7fd 
* Backport #33348
* Backport #33820

---------

Co-authored-by: yp05327 <[email protected]>
@lafriks lafriks enabled auto-merge (squash) March 7, 2025 19:31
@lafriks lafriks merged commit b8c2afd into go-gitea:main Mar 7, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-passkey-err branch March 8, 2025 02:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7aa16d2 
* giteaofficial/main:
  Move notifywatch to service layer (go-gitea#33825)
  [skip ci] Updated translations via Crowdin
  Only keep popular licenses (go-gitea#33832)
  Removing unwanted ui container (go-gitea#33833)
  Full-file syntax highlighting for diff pages (go-gitea#33766)
  Improve theme display (go-gitea#30671)
  Decouple context from repository related structs (go-gitea#33823)
  Improve log format (go-gitea#33814)
  Decouple diff stats query from actual diffing (go-gitea#33810)
  Add global lock for migrations to make upgrade more safe with multiple replications (go-gitea#33706)
  Do not show passkey on http sites (go-gitea#33820)
hiifong pushed a commit to hiifong/gitea that referenced this pull request Mar 10, 2025
@wxiaoguang @hiifong
Do not show passkey on http sites (go-gitea#33820)
8943909 
Fix go-gitea#33615

(cherry picked from commit b8c2afd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

WebAuthn failure on HTTP instance with a custom domain
5 participants
@wxiaoguang @lunny @lafriks @ChristopherHX @GiteaBot