Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless check #3384

Merged
merged 3 commits into from
Jan 19, 2018
Merged

Remove useless check #3384

merged 3 commits into from
Jan 19, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 16, 2018

In #3377, I put check inside all write key function to enforce it since sometimes it wasn't done before calling those methods.
This one is useless no.

@sapk
Remove useless check
f3f04e1 
In go-gitea#3377, I put check inside all write key function. This one is useless no.
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 16, 2018
@codecov-io
Copy link

codecov-io commented Jan 16, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@05ab747). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3384   +/-   ##
=========================================
  Coverage          ?   35.61%           
=========================================
  Files             ?      281           
  Lines             ?    40552           
  Branches          ?        0           
=========================================
  Hits              ?    14442           
  Misses            ?    23974           
  Partials          ?     2136
Impacted Files Coverage Δ
models/ssh_key.go 39.2% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ab747...27eed43. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 16, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2018
@lunny
Copy link
Member

lunny commented Jan 16, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2018
@lafriks lafriks merged commit 1ce3572 into go-gitea:master Jan 19, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 19, 2018
@sapk sapk deleted the remove-useless-check branch May 19, 2018 23:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sapk @codecov-io @lunny @lafriks @tboerger