Prevent nil dereference in mailIssueCommentToParticipants (#5891, #5895) #5894
Conversation
…itea#5891) Previous code could potentially dereference nil - this PR ensures that the poster is loaded before dereferencing it. Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
changed the title
| @@ -88,6 +88,10 @@ func mailIssueCommentToParticipants(e Engine, issue *Issue, doer *User, content | |||
| names = append(names, participants[i].Name) | |||
| } | |||
|
|
|||
| if err := issue.loadRepo(e); err != nil { | |||
There was a problem hiding this comment.
This changes are not in the original PR #5891
There was a problem hiding this comment.
Yup as per: #5891 (comment)
I noticed another nil dereference.
There was a problem hiding this comment.
Happy to remove and do another PR if preferred.
There was a problem hiding this comment.
Ideally, I'd prefer it in another PR since backports are basically cherrypicked.
There was a problem hiding this comment.
The only trouble is that the PR doesn't then completely fix the bug...
@techknowlogick Should we keep the repo fix in this PR or make another with it separately?
There was a problem hiding this comment.
Yeah, preferably two PRs for the reasons @adelowo listed above. However in this case I think we can keep it as one PR.
GiteaBot
added
the
lgtm/need 2
techknowlogick
changed the title
zeripath
changed the title
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
The previous code could potentially dereference nil - this PR ensures
that the poster and the repo are loaded before dereferencing them.
#5891
Signed-off-by: Andrew Thornton [email protected]