Update slogtest empty-group-record explanation #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Diniz <[email protected]>
pohly
reviewed
Jan 21, 2025
| "a Handler should ignore a zero Record.Time", // zapr always writes a time field. | ||
| "a Handler should not output groups for an empty Record", // Relies on WithGroup and that always opens a group. Text may change, see https://go.dev/cl/516155 | ||
| "a Handler should ignore a zero Record.Time", // zapr always writes a time field. | ||
| "a Handler should not output groups if there are no attributes", // Relies on WithGroup and that always opens a group. |
There was a problem hiding this comment.
We might have to keep the old string to avoid errors when using an old Go version.
That aside, golang/go#61758 probably got merged long enough ago that we can skip unsupported sub-tests as outlined in golang/go#65400 (comment).
Can you give that a try instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit https://go.dev/cl/516155 changed the explanation regarding empty group handling, causing TestSlogHandler to fail.
This Pull Request updates the corresponding test message:
https://cs.opensource.google/go/go/+/master:src/testing/slogtest/slogtest.go;l=161
This aligns the test with the new behavior and ensures it passes.