Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass kwargs on to custom classes #116

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Pass kwargs on to custom classes #116

merged 2 commits into from
Aug 12, 2021

Conversation

JoeSouthan
Copy link
Contributor

@JoeSouthan JoeSouthan commented Aug 11, 2021 •
edited
Loading

Running this under ruby 2.7 leads to a deprecation warning:

DEPRECATION WARNING: nandi/lib/nandi/migration.rb:362: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
nandi/lib/nandi/migration.rb:384: warning: The called method `invoke_custom_method' is defined here
```

JoeSouthan and others added 2 commits August 11, 2021 18:20
@JoeSouthan
Pass kwargs on to custom classes
e08728d
Remove structs from tests
7f5fa7e 
To fix compatibility between Ruby 2.5/6 and 3.0.
@tragiclifestories tragiclifestories merged commit fa2c9a6 into master Aug 12, 2021
@JoeSouthan JoeSouthan deleted the joesouthan/nandi-fixes branch August 12, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tragiclifestories tragiclifestories tragiclifestories approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeSouthan @tragiclifestories