-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #60
Update README.md #60
Conversation
add the correct canonical way of importing go modules that are greater than or equal to version 2
I'm not sure this is enough, in its current form. What about users of package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier comment. I don't think merging this as-is is right.
Maybe:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. Would you please make this a comment above instead? I'm not totally sold on the phrasing I'm suggesting here, but here's the rough idea:
import (
"log"
// if using modules you may want github.com/gofrs/uuid/v3 instead
"github.com/gofrs/uuid"
)
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 4 4
Lines 279 279
=======================================
Hits 276 276
Misses 2 2
Partials 1 1 Continue to review full report at Codecov.
|
Let's hold off on this until #61 is resolved. It seems tricky. |
We're about to merge a change to remove module support, which deprecates this PR. Thank you for the contribution and I'm sorry we weren't able to use it. We'll definitely resurrect something similar in the future depending on how modules shake out. |
add the correct canonical way of importing go modules that are greater than or equal to version 2