remove redis sentinel patch from builder #21679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yminer <[email protected]>
MinerYang
added
release-note/update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21679 +/- ##
==========================================
+ Coverage 45.36% 46.28% +0.92%
==========================================
Files 244 250 +6
Lines 13333 14133 +800
Branches 2719 2908 +189
==========================================
+ Hits 6049 6542 +493
- Misses 6983 7246 +263
- Partials 301 345 +44
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
approved these changes
Feb 28, 2025
wy65701436
reviewed
Mar 3, 2025
| @@ -28,9 +28,6 @@ cur=$PWD | |||
| TEMP=`mktemp -d ${TMPDIR-/tmp}/distribution.XXXXXX` | |||
| git clone -b $VERSION $DISTRIBUTION_SRC $TEMP | |||
|
|
|||
| # add patch redis | |||
| cd $TEMP | |||
| git apply $cur/redis.patch | |||
| cd $cur | |||
There was a problem hiding this comment.
this should be removed together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Since we will use harbor/distribution since release-2.13, the redis sentinel patch will be removed from builder.