Display content/_index.md if it exists #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gokarna-hugo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@jamesericdavidson The hugo build command is breaking, might want to make sure it works on your local first |
|
I think this is related to the fileExists function. Works on a local server, but GitLab CI/CD and GitHub build checks aren't happy. I'll have a look!
Regards,
James Davidson
…-------- Original Message --------
On 16 Aug 2022, 06:04, Yash Mehrotra wrote:
***@***.***(https://github.com/jamesericdavidson) The hugo build command is breaking, might want to make sure it works on your local first
—
Reply to this email directly, [view it on GitHub](#119 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A2GRSNTOKOQWGL7AZUQZX5DVZMOPXANCNFSM56S4P4TA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@yashmehrotra I committed a bad version of the file, but it's now fixed. Additionally evaluating that |
Comment on lines
224
to
227
| ### Displaying content on the homepage | ||
|
|
||
| Content to display on homepage below the social icons, using the contents of `content/_index.md`. | ||
|
|
There was a problem hiding this comment.
@jamesericdavidson This should not be deleted, this documentation is still useful
There was a problem hiding this comment.
Yes, you're right. I only wanted to remove the reference to enableFrontMatter.
This should've been an atomic commit as well, oops. Re-added.
|
Thanks, merging |
|
Thanks for merging |
jamesericdavidson
added a commit
to jamesericdavidson/gokarna
that referenced
this pull request
Sep 12, 2022
jamesericdavidson
added a commit
to jamesericdavidson/gokarna
that referenced
this pull request
Jan 21, 2025
re-implement gokarna-theme#119 - the Hugo way of displaying front matter - without breaking index-about.md (gokarna-theme#179) https://gohugo.io/content-management/organization/#index-pages-_indexmd if _index.md exists (and has content), print it else, if index-about.md exists (without checking for file contents), print it
yashmehrotra
pushed a commit
that referenced
this pull request
Feb 1, 2025
* refactor(index): support _index.md re-implement #119 - the Hugo way of displaying front matter - without breaking index-about.md (#179) https://gohugo.io/content-management/organization/#index-pages-_indexmd if _index.md exists (and has content), print it else, if index-about.md exists (without checking for file contents), print it * style(css): rename markdown-content class * docs: update _index.md filename * style(index): remove hr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for #109. Test if
content/_index.mdexists, instead of configuringenableFrontMatter.I thought the condition for displaying content on the home page could be made more convenient for people switching themes, or who want to add native Hugo front matter without theme configuration.