misc/android: evaluate symlinks before comparing GOROOT and GOPATH

Should fix Android builders on Darwin hosts. Change-Id: I1554849bdf2ad2440529af7f93566fa6f11d5407 Reviewed-on: https://go-review.googlesource.com/c/164697 Run-TryBot: Elias Naur <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
golang · Mar 1, 2019 · d24c312 · d24c312
1 parent 38642b9
commit d24c312
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/misc/android/go_android_exec.go b/misc/android/go_android_exec.go
@@ -156,19 +156,27 @@ func subdir() (pkgpath string, underGoRoot bool) {
 	if err != nil {
 		log.Fatal(err)
 	}
-	if root := runtime.GOROOT(); strings.HasPrefix(cwd, root) {
-		subdir, err := filepath.Rel(root, cwd)
+	goroot, err := filepath.EvalSymlinks(runtime.GOROOT())
+	if err != nil {
+		log.Fatal(err)
+	}
+	if strings.HasPrefix(cwd, goroot) {
+		subdir, err := filepath.Rel(goroot, cwd)
 		if err != nil {
 			log.Fatal(err)
 		}
 		return subdir, true
 	}
 
 	for _, p := range filepath.SplitList(build.Default.GOPATH) {
-		if !strings.HasPrefix(cwd, p) {
+		pabs, err := filepath.EvalSymlinks(p)
+		if err != nil {
+			log.Fatal(err)
+		}
+		if !strings.HasPrefix(cwd, pabs) {
 			continue
 		}
-		subdir, err := filepath.Rel(p, cwd)
+		subdir, err := filepath.Rel(pabs, cwd)
 		if err == nil {
 			return subdir, false
 		}